# HG changeset patch # User Robert Casties # Date 1528475338 -7200 # Node ID ca83d67a2dc9b7a57c01e33b3ef41efd8b3011b9 # Parent af1018d064438edef27ea826a924e3c8d81332d8 bugfix and nicer messages for PublicByAuthor feature. diff -r af1018d06443 -r ca83d67a2dc9 src/main/java/de/mpiwg/itgroup/ismi/entry/beans/SessionBean.java --- a/src/main/java/de/mpiwg/itgroup/ismi/entry/beans/SessionBean.java Fri Jun 08 17:03:35 2018 +0200 +++ b/src/main/java/de/mpiwg/itgroup/ismi/entry/beans/SessionBean.java Fri Jun 08 18:28:58 2018 +0200 @@ -139,7 +139,7 @@ private String selectedTab = WITNESS_TAB; private String selectedEventTab = WITNESS_STUDY_EVENT_TAB; private String selectedAdvancedSearchTab = "01"; - private String selectedPublicByAuthorTab = "01"; + private String selectedPublicByAuthorTab = "aut"; private Long editFormCurrentEntId; diff -r af1018d06443 -r ca83d67a2dc9 src/main/java/de/mpiwg/itgroup/ismi/merge/PublicByAuthorBean.java --- a/src/main/java/de/mpiwg/itgroup/ismi/merge/PublicByAuthorBean.java Fri Jun 08 17:03:35 2018 +0200 +++ b/src/main/java/de/mpiwg/itgroup/ismi/merge/PublicByAuthorBean.java Fri Jun 08 18:28:58 2018 +0200 @@ -49,7 +49,7 @@ this.reset(); } - public void reset(){ + public synchronized void reset(){ logger.info("PublicByAuthorBean.reset()"); browseBean = new FullEntityRepositoryBean(); browseBean.setObjectClass(PERSON); @@ -237,6 +237,7 @@ */ public String actionMakeTextAndRelatedPublic() { Entity text = (Entity) getRequestBean("text"); + logger.info("MAKE PUBLIC by text for text="+text.getOwnValue()); List textMsg = new ArrayList(); try { List entities = PrivacityUtils.setTextAndMorePrivacity(text, true, textMsg, getWrapper()); @@ -245,11 +246,11 @@ } catch (Exception e) { logger.error(e); } - logger.debug("MAKE TEXT PUBLIC"); for (String msg : textMsg) { this.addGeneralMsg(msg); logger.debug(msg); } + addGeneralMsg("The text \""+text.getOwnValue()+"\" was made public!"); return null; } @@ -260,7 +261,8 @@ */ public String actionMakePersonSubjectAndRelatedPublic() { String subject = (String) getRequestBean("subject"); - logger.debug("MAKE SUBJECT PUBLIC"); + logger.info("MAKE PUBLIC by author and subject for author="+selectedPerson.getOwnValue()+" and subject="+subject); + int pubCnt = 0; List texts = selectedPersonSubjectMap.get(subject); for (Entity text : texts) { List textMsg = new ArrayList(); @@ -275,7 +277,9 @@ this.addGeneralMsg(msg); logger.debug(msg); } + pubCnt += 1; } + addGeneralMsg(pubCnt+" texts with subject "+subject+" were made public!"); return null; } @@ -286,7 +290,7 @@ */ public String actionMakeMamsSubjectAndRelatedPublic() { String subject = (String) getRequestBean("subject"); - logger.debug("MAKE PUBLIC BY MAMS AND SUBJECT"); + logger.info("MAKE PUBLIC by MAMS and subject for subject="+subject+" and maxMams="+maxMamsNr); if (maxMamsNr < 1) { addErrorMsg("MAMS number too small!"); return null; @@ -369,13 +373,6 @@ } /** - * @return the selectedPersonId - */ - public long getSelectedPersonId() { - return selectedPersonId; - } - - /** * @return the selectedPerson */ public Entity getSelectedPerson() { @@ -399,11 +396,18 @@ /** * @param selectedPersonId the selectedPersonId to set */ - public void setSelectedPersonId(Long selectedPersonId) { + public void setSelectedPersonId(long selectedPersonId) { this.selectedPersonId = selectedPersonId; } /** + * @return the selectedPersonId + */ + public long getSelectedPersonId() { + return selectedPersonId; + } + + /** * @return the selectedPersonSubjects */ public List getSelectedPersonSubjects() { diff -r af1018d06443 -r ca83d67a2dc9 src/main/webapp/clean/components/publicAuthorSubjects.xhtml --- a/src/main/webapp/clean/components/publicAuthorSubjects.xhtml Fri Jun 08 17:03:35 2018 +0200 +++ b/src/main/webapp/clean/components/publicAuthorSubjects.xhtml Fri Jun 08 18:28:58 2018 +0200 @@ -14,7 +14,7 @@ -

Author: #{Session.publicByAuthor.selectedPerson.ownValue}"

+

Author: #{Session.publicByAuthor.selectedPerson.ownValue}

diff -r af1018d06443 -r ca83d67a2dc9 src/main/webapp/clean/components/publicFindAuthor.xhtml --- a/src/main/webapp/clean/components/publicFindAuthor.xhtml Fri Jun 08 17:03:35 2018 +0200 +++ b/src/main/webapp/clean/components/publicFindAuthor.xhtml Fri Jun 08 18:28:58 2018 +0200 @@ -9,10 +9,6 @@ - - - - @@ -31,13 +27,10 @@ actionListener="#{Session.publicByAuthor.browseBean.actionSearchByAttributes}" render="selectPersonPanel" /> - - + style="margin-left: auto; margin-right: auto; text-align: center; width: 100%;">