Changeset 59:e2f86ef9b871 in AnnotationManagerN4J for src/main/java

Timestamp:

Nov 20, 2012, 6:16:43 PM (12 years ago)

Author:

casties

Branch:

default

Message:

make annotation uri in store configurable. fix npe with no tags.

Location:

src/main/java/de/mpiwg/itgroup/annotations

Files:

• neo4j/AnnotationStore.java (modified) (16 diffs)
• restlet/BaseRestlet.java (modified) (2 diffs)

src/main/java/de/mpiwg/itgroup/annotations/neo4j/AnnotationStore.java

@@ -56 +56 @@
     }
 
-    public static String ANNOTATION_URI_BASE = "http://entities.mpiwg-berlin.mpg.de/annotations/";
+    public static String ANNOTATION_URI_PREFIX = "";
 
     public AnnotationStore(GraphDatabaseService graphDb) {
@@ -80 +80 @@
      */
     public Node getPersonNodeByUri(String userUri) {
-        if (userUri == null) return null;
-        Node person = getNodeIndex(NodeTypes.PERSON).get("uri", userUri).getSingle();
-        return person;
+        return getNodeFromIndex("uri", userUri, NodeTypes.PERSON);
     }
 
@@ -90 +88 @@
      */
     public Node getTagNodeByUri(String tagUri) {
-        if (tagUri == null) return null;
-        Node person = getNodeIndex(NodeTypes.TAG).get("uri", tagUri).getSingle();
-        return person;
+        return getNodeFromIndex("uri", tagUri, NodeTypes.TAG);
     }
 
@@ -112 +108 @@
 
     /**
-     * Returns the Node with the given key and value.
-     * Key has to be indexed.
+     * Returns the Node with the given key and value. Key has to be indexed.
      * 
      * @param key
@@ -122 +117 @@
     public Node getNodeFromIndex(String key, String value, NodeTypes type) {
         if (key == null || value == null) return null;
-        Node person = getNodeIndex(type).get(key, value).getSingle();
-        return person;
-    }
-
-    /**
-     * Returns list of Actors of given type (Group or Person).
-     * Key has to be indexed.
+        Node node = getNodeIndex(type).get(key, value).getSingle();
+        return node;
+    }
+
+    /**
+     * Returns list of Actors of given type (Group or Person). Key has to be
+     * indexed.
      * 
      * @param key
@@ -150 +145 @@
         return actors;
     }
-    
+
     /**
      * Returns list of groups. Key has to be indexed.
+     * 
      * @param key
      * @param query
@@ -161 +157 @@
         return groups;
     }
-    
+
     /**
      * Returns list of Persons. Key has to be indexed.
+     * 
      * @param key
      * @param query
@@ -172 +169 @@
         return persons;
     }
-    
-    /**
-     * Returns list of uri-like objects of given type (Target or Resource).
-     * Key has to be indexed.
+
+    /**
+     * Returns list of uri-like objects of given type (Target or Resource). Key
+     * has to be indexed.
      * 
      * @param key
@@ -198 +195 @@
     }
 
-    
     /**
      * Returns list of Targets. Key has to be indexed.
+     * 
      * @param key
      * @param query
@@ -209 +206 @@
         return targets;
     }
-    
+
     /**
      * Returns list of Resources. Key has to be indexed.
+     * 
      * @param key
      * @param query
@@ -220 +218 @@
         return targets;
     }
-    
-    /**
-     * Returns List of Annotations.
-     * Key has to be indexed.
+
+    /**
+     * Returns List of Annotations. Key has to be indexed.
      * 
      * @param key
@@ -244 +241 @@
     }
 
- 
-    
-    /**
-     * Returns List of Tags.
-     * Key has to be indexed.
+    /**
+     * Returns List of Tags. Key has to be indexed.
      * 
      * @param key
@@ -596 +590 @@
         return (Resource) createUriFromNode(resourceNode);
     }
-    
+
     /**
      * @param targetNode
@@ -604 +598 @@
         return (Target) createUriFromNode(targetNode);
     }
-    
-    
+
     protected Uri createUriFromNode(Node uriNode) {
         if (uriNode == null) return null;
@@ -1083 +1076 @@
      */
     private String createRessourceURI(String prefix) {
-
         Calendar cal = Calendar.getInstance();
-
         long time = cal.getTimeInMillis();
-
-        return String.format("%s%s%s", ANNOTATION_URI_BASE, prefix, time);
-
+        return String.format("%s%s%s", ANNOTATION_URI_PREFIX, prefix, time);
     }
 
     public List<Annotation> getAnnotationsByTag(String tagUri) {
-
         ArrayList<Annotation> ret = new ArrayList<Annotation>();
         Node tag = getTagNodeByUri(tagUri);
-
-        Iterable<Relationship> rels = tag.getRelationships(Direction.INCOMING, RelationTypes.HAS_TAG);
-
-        for (Relationship rel : rels) {
-            Node node = rel.getStartNode();
-            ret.add(createAnnotationFromNode(node));
-
+        if (tag != null) {
+            Iterable<Relationship> rels = tag.getRelationships(Direction.INCOMING, RelationTypes.HAS_TAG);
+            for (Relationship rel : rels) {
+                Node node = rel.getStartNode();
+                ret.add(createAnnotationFromNode(node));
+            }
         }
         return ret;
@@ -1109 +1096 @@
     public List<Annotation> getAnnotationsByResource(String resourceUri) {
         ArrayList<Annotation> ret = new ArrayList<Annotation>();
-        Node tag = getNodeFromIndex("uri", resourceUri, NodeTypes.RESOURCE);
-        Iterable<Relationship> rels = tag.getRelationships(Direction.INCOMING, RelationTypes.ANNOTATES);
-        for (Relationship rel : rels) {
-            Node an = rel.getStartNode();
-            Node rn = rel.getEndNode();
-            if (rn.getProperty("TYPE", "").equals("RESOURCE")) {
-                logger.error("getAnnotationsByResource got ANNOTATES != RESOURCE");
-            }
-            ret.add(createAnnotationFromNode(an));
+        Node res = getNodeFromIndex("uri", resourceUri, NodeTypes.RESOURCE);
+        if (res != null) {
+            Iterable<Relationship> rels = res.getRelationships(Direction.INCOMING, RelationTypes.ANNOTATES);
+            for (Relationship rel : rels) {
+                Node an = rel.getStartNode();
+                Node rn = rel.getEndNode();
+                if (rn.getProperty("TYPE", "").equals("RESOURCE")) {
+                    logger.error("getAnnotationsByResource got ANNOTATES != RESOURCE");
+                }
+                ret.add(createAnnotationFromNode(an));
+            }
         }
         return ret;

src/main/java/de/mpiwg/itgroup/annotations/restlet/BaseRestlet.java

@@ -99 +99 @@
     public static String GROUPS_URI_PREFIX = ""; 
     public static final String GROUPS_URI_KEY = "annotationmanager.uris.groups";
+
+    public static final String ANNOTATIONS_URI_KEY = "annotationmanager.uris.annotations";
 
     /**
@@ -218 +220 @@
                 BaseRestlet.TAGS_URI_PREFIX = tup;
             }
+            String aup = (String) sc.getAttribute(ANNOTATIONS_URI_KEY);
+            if (aup != null) {
+                AnnotationStore.ANNOTATION_URI_PREFIX = aup;
+            }
         } else {
             logger.error("Unable to get ServletContext!");