Changeset 105:7417f5915181 in AnnotationManagerN4J for src/main/java/de/mpiwg/itgroup/annotations/Annotation.java

Timestamp:

Feb 10, 2017, 2:45:35 PM (7 years ago)

Author:

casties

Branch:

default

Tags:

tip

Message:

check admin permission before changing permissions.
Enum for typesafe actions.

File:

• src/main/java/de/mpiwg/itgroup/annotations/Annotation.java (modified) (5 diffs)

src/main/java/de/mpiwg/itgroup/annotations/Annotation.java

@@ -132 +132 @@
     
     /**
+     * Enum of actions (for permissions).
+     */
+    public static enum Action {
+        read, update, create, delete, admin
+    }
+    
+    /**
      * Returns if the requested action is allowed for the given user on this annotation.
      * 
@@ -139 +146 @@
      * @return
      */
-    public boolean isActionAllowed(String action, Person user, AnnotationStore store) {
-        if (action.equals("read")) {
+    public boolean isActionAllowed(Action action, Person user, AnnotationStore store) {
+        if (action == Action.read) {
             Actor reader = getReadPermission();
             if (reader == null) {
@@ -148 +155 @@
                 return reader.isEquivalentWith(user, store);
             }
-        } else if (action.equals("update")) {
+        } else if (action == Action.update) {
             // require at least an authenticated user
             if (user == null) return false;
@@ -158 +165 @@
                 return updater.isEquivalentWith(user, store);
             }
-        } else if (action.equals("delete")) {
+        } else if (action == Action.delete) {
             // require at least an authenticated user
             if (user == null) return false;
@@ -167 +174 @@
             }
             return deleter.isEquivalentWith(user, store);
-        } else if (action.equals("admin")) {
+        } else if (action == Action.admin) {
             // require at least an authenticated user
             if (user == null) return false;